You are viewing a single comment's thread from:

RE: COLOR GRADIENTS ON TRACKS AND SPANS FLASH IN TIME WITH THE AUDIO BEING PLAYED: a new feature for the open-source project The Amanuensis: Automated Songwriting and Recording

in #utopian-io6 years ago

Thank you very much for your contribution.

  1. The post is well written and descriptive.
  2. The timelineGL.js as I understand, you are modifying on somebody else' code, it would be nice to have a list of changes in the header comment.
  3. for(i = 1; i <= tracks; i++) { a code smell that you forgot to put var or let, which could make i a global variable , same as the variable a in line 737 which is just bad.
  4. new Array() could be shortened as [];
  5. commented-out code in general is not a good idea, you 'd better just remove them.
  6. Congratulations, you have introduced Javascript in this repro, could we unit test the changes you've made?

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Okay, thanks for all the tips. If you want to test it out, please do!

Thank you for your review, @justyy! Keep up the good work!