Thank you very much for your contribution.
- The post is well written and descriptive.
- The
timelineGL.js
as I understand, you are modifying on somebody else' code, it would be nice to have a list of changes in the header comment. for(i = 1; i <= tracks; i++) {
a code smell that you forgot to putvar
orlet
, which could makei
a global variable , same as the variablea
in line 737 which is just bad.new Array()
could be shortened as[]
;- commented-out code in general is not a good idea, you 'd better just remove them.
- Congratulations, you have introduced Javascript in this repro, could we unit test the changes you've made?
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Okay, thanks for all the tips. If you want to test it out, please do!
Thank you for your review, @justyy! Keep up the good work!