You are viewing a single comment's thread from:

RE: Utbot, the bot for a standard format of Utopian submissions in Discord

in #utbot6 years ago

Looks great. :)

  • There was a small problem on installation instructions. Just sent a PR.

  • Looks like you have defined a helper function (is_utopian_contribution on utils package and import it in the utbot.py, yet, you don't use it in the bot.)

  • Good use of type annotations. :)

Some minor issues includes personal preference:

  • The upper case choice on LOGGER variable kinda feels wrong. It should be a constant variable if you do that. (convention) I think, the logger is something you can mutate and shouldn't be considered as constant.

  • I see some long lines. PEP8 encourages 80 or 100.


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.



Chat with us on Discord.
[utopian-moderator]Need help? Write a ticket on https://support.utopian.io/.

Sort:  

Hey, thanks for the notes. I will fix the issues. Regarding the length of the lines, I suppose I let some of the strings be too long. Otherwise, I use black formatter which encourages not to stick to 80 chars on a line.

Thank you for your review, @emrebeyler! Keep up the good work!