Looks like a very useful project for people who have multiple accounts, great stuff! As @geronimo said, it would make a lot of sense to have a UI for the laymen out there - hopefully someone takes on that task for you.
As for the code itself:
- Great to see you included so many tests!
- Was wondering what
__awaiteris - it's duplicated across multiple files many times, which could maybe be refactored. - There are a lot of functions like
steem_to_vest,power_upetc. that I presume you also use in other projects; can't you make an npm package for these (I'm not exactly knowledgable about doing this, so I could be completely wrong). - Some small inconsistencies that could be fixed by using a linter, but other than that, it looks like a lot of high quality work.
- Would be better to split up the commits instead of having one big one, but you know that already.
- Great documentation on how to use the config!
Another great project from you, as always. Thanks for all the amazing work you do on the blockchain!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
I think so as well! :D
__awaiteris part of the compiled codedist. Normally, I don't ship this but when I'm expecting end-users to handle them, I do. It's def. not best practice and I might stop doing that in the future.That's actually a goal, but I didn't have enough time for that and I didn't want to push something half-backed :D
I had 50+ commits, but reduced them to one, simply as an initial commit.
Thanks for the in-depth feedback!
Would be great, as I will be needing something like this in the future, haha!
WOMAN; you fall in love with the features that make you happy, and they try to take that feature from you.
Thank you for your review, @amosbastian! Keep up the good work!