Nice one for an updated post.
Just a couple of comments and most of the time might not even give problems but as a good practice, we want to respect the contents of the package-lock.json
file for most of the modules, hence on the npm
command that does not target any install package, we want to use the c
flag too.
npm ci
The other comment is that may be not obvious, but people need to check which tags are the latest and maybe it would pay off to add a comment before this line, saying to check the latest tag version:
GIT_TAG=he_v1.7.1
Question... why is this part for?
################
## RESTORE DB ##
################
mongo --eval "rs.initiate()"
systemctl restart mongod
Maybe you meant to add the mongorestore
command here? Just mentioning because it was already done above, the initiate command.
Cheers
Thanks for the npm 'c' flag, didn't know that!
And the final mongo stuff were some tweaks I did before when the database was huge that I just carried over. It's likely this can be removed today.
👍