You are viewing a single comment's thread from:

RE: Vessel v0.4.1 - Into the Hive!

in HiveDevs5 years ago

Hey, @netuoso I re-forked your Vessel repo to fix some stuff I see and can test locally, you are welcome to copy paste or just merge: https://github.com/4Ykw/vessel/tree/fix-hive-migration

Not sure the best way to help, but because I wanna test some local stuff too. =) decided to fork it.

I am used to work on branches to fix stuff and upon agreement, either merge to my repo master first and then others, or if I am the only coder for my repo, then just directly to others (unless I have stuff I wanna test in a pipeline or something like that).

Sort:  

Awesome will check out what you added and merge in soon!

After looking at what I though a easy come back ... I realized I am not used to npm and yarn anymore... lost all knowledge. Plus the mess of cross resolving is crazy compared to what I am used to deal with.

Trying to test what I thought to be an easy commit. But now that I have seen you have actually added the change HIVE>STEEM on the powerUp function, I am not sure anymore if that was because it was dependent on the steemjs. Anyway, if it was, disregards that commit.

I also saw you started a @hiveio/hive.js. Are you going to switch to that over the next updates of Vessel?

Last question, and this is one of the reasons to play with this, any thoughts about adding the change_recovery_account which is something called "reset" on the js lib...?

Cheers and thanks for the fast replies. No rush on this.

I have seen already that the party has just started again on the Justin side... what a jerk...

Change recovery account will be a great addition. Thank you for that suggestion; I've added it to the TODO.

Npm/Yarn and all the Vessel goodness can get a little annoying with setting up the dev environment. One of my coming pushes will update all the NPM dependencies and provide a start script and a Dockerized build. That may make things easier to get up to speed!

That would be super... =)