I only have experience with the Ledger Nano S and I really like it. There is one limitation I really don't like though, each coin you want to store requires an app on the Ledger. This isn't a big deal as you can add/remove apps in like 10 seconds after unlocking the device.
The problem is you can only have four installed at once. For me, that's Bitcoin, Bitcoin Cash, Ethereum, Litecoin. If I also want to use the wallet for ZCash and Dash or any of the other 15-20 coins, you need to uninstall one of the apps and install the other app.
There are only two apps on the desktop, one for Bitcoin and all the altcoins, and one for Etherum and all the ERC20 tokens.
Uninstalling an app doesn't remove the wallet, you still have your coins, you just can't have them all readily available. There is one other app that is installed that doesn't seem to count towards the limit is Fido U2F, which is really cool tech that acts as a 2nd or third factor of authentication. You can use it for example as a backup if you don't have your Google Authenticator available or your phone is lost. Unfortunately, most sites don't support backup 2nd factor, but Google does.
I like the Ledger Nano S better than I expected, but that limitation is bs as it would have been so easy to avoid with a tiny bit more memory.
I do like how you can have many wallets in your app, so for example Bitcoin Cash I have my main wallet, but I now have one for my son, they are both listed inside of the Bitcoin Cash app.
The Ledger is more secure as it supports an 8 digit pin if you want to go past 4 and hasn't been previously hacked like the Trezor (which allowed anyone to get all the bitcoins out within 15 seconds and the private keys left the device, one of the big no-noes of a hardware wallet). That issue has been fixed but makes me uncomfortable.
I do want to try a Trezor and now they have a new Trezor coming out with a touch screen.